OPIK-645 Return all feedback score names for project ids endpoint #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrescrz
reviewed
Dec 23, 2024
apps/opik-backend/src/main/java/com/comet/opik/api/resources/v1/priv/ProjectsResource.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/resources/v1/priv/ProjectsResource.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/FeedbackScoreDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/FeedbackScoreDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/FeedbackScoreDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/FeedbackScoreDAO.java
Show resolved
Hide resolved
...ackend/src/test/java/com/comet/opik/api/resources/utils/resources/ProjectResourceClient.java
Outdated
Show resolved
Hide resolved
Comment on lines
2696
to
2697
| var feedbackScoreNamesByProjectId = projectResourceClient.findFeedbackScoreNames(projectIdsQueryParam, apiKey, workspaceName); | ||
| assertFeedbackScoreNames(feedbackScoreNamesByProjectId, expectedNames); |
There was a problem hiding this comment.
This should be a new test for project resource, not under the experiments resource.
There was a problem hiding this comment.
I moved it to ProjectsResourceTest and did some refactoring.
BorisTkachenko
force-pushed
the
boryst/OPIK-645-be-add-endpoint-to-return-all-possible-feedback-scores-names-for-projects
branch
from
cfd71c8 to
888ed03
Compare
idoberko2
reviewed
Jan 2, 2025
| project, apiKey, workspaceName); | ||
|
|
||
| // Create unexpected feedback scores | ||
| var unexpectedProject = factory.manufacturePojo(Project.class); |
There was a problem hiding this comment.
I believe you forgot to make the call that actually creates the project
idoberko2
previously approved these changes
Jan 2, 2025
idoberko2
approved these changes
Jan 2, 2025
BorisTkachenko
deleted the
boryst/OPIK-645-be-add-endpoint-to-return-all-possible-feedback-scores-names-for-projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Return all feedback score names for project ids endpoint
Testing
Covered by integration test