Updating example Jupyter Notebook to utilize the updated colour
API
#71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request fixes:
example_detection.ipynb
notebook where there's a call to create acolour.characterisation.ColourChecker
instance without passing therows
andcolumns
arguments of the named tuple, leading to the following errorcolour.RGB_to_XYZ
andcolour.XYZ_to_RGB
inexample_detection.ipynb
that utilize the deprecated(data, source_illuminant, target_illuminant, matrix)
argument pattern instead of the (data, colourspace, source_illuminant)
argument pattern for these functions. (A change that came with Colour v0.4.3) This deals with warningsPreflight
Code Style and Quality
This PR does not modify any source code, it only updates the
example_detection.ipynb
notebook. So I'm assuming that the tests, checks, and documentation updates do not necessarily apply. I did re-run the entire notebook to test this PR; however, I did not include the re-run notebook in this PR as to avoid a massive diff, but please let me know if there's a better way to approach this.Documentation