Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Sending and custom field mapping #22

Merged
merged 13 commits into from
May 23, 2023
Merged

XML Sending and custom field mapping #22

merged 13 commits into from
May 23, 2023

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Nov 23, 2022

Requires collective/volto-form-block#52

This PR adds supports for attaching an XML file containing the data submitted in the form to the email. This feature is available in collective.easyform and may be useful to those transitioning to Volto. To further help transition collective.easyform users who may be reliant on specific field IDs when using collective.easyform, the ability to customise the label for sending/ downloading XML and CSV was also added.

The below video demonstrates the custom value mapping when downloading the CSV file. The XML after the video was the contents of the file attached to the email sent when submitting the form.

Screen.Recording.2022-11-23.at.7.33.22.pm.mov
<?xml version='1.0' encoding='utf-8'?><form><field name="Custom field label">My value</field></form>

@JeffersonBledsoe JeffersonBledsoe requested a review from cekk March 8, 2023 10:55
Copy link
Collaborator

@cekk cekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it's good to keep easyform functionalities.

Can you please update also the changelog and readme with some infos about this new feature?

# Conflicts:
#	setup.py
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
@JeffersonBledsoe
Copy link
Member Author

@cekk I've updated the changelog and docs. Docs aren't my strong point so would you mind having a look over them before merging? 🙂

@JeffersonBledsoe JeffersonBledsoe requested a review from cekk April 20, 2023 12:20
@cekk
Copy link
Collaborator

cekk commented Apr 21, 2023

looks good..can you provide some tests for this new feature (sorry, i forgot to tell you)

@JeffersonBledsoe
Copy link
Member Author

@cekk Added test!

@cekk
Copy link
Collaborator

cekk commented May 23, 2023

Cool, thanks!

@cekk cekk merged commit 15101d6 into main May 23, 2023
@cekk cekk deleted the xml-sending branch May 23, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants