-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive tests and improve the tests runner #25
Conversation
...cause they're for debug, y'know.
The test runner is now looking much better. It compiles, the code is cleaner and its error reporting is also much better. Still, a few things remain before we can do anything with it:
|
Additional thought:
|
I think that, at this point, we can consider that the tests are fixed indeed. CI is unpleased because Morsmall is broken in many ways, but that is not so much the problem of the tests. We do need to fix these last three points but I will open issues for all of them before merging this PR. |
This PR is here to bring back the tests that we have (and that aren't that much to begin with). There will be several parts to this:
dune test
does what we expect.Edit: mentioned later in the PR:
The comparison of ASTs should be made without comparing the locations. (This is maybe already the case but it should then be documented.)Edit: Introduce an AST equality that ignore the locations #31The printing of ASTs in JSON should hide the locations in the test runner. In general, we should provide two different serialisers, one with and one without locations. Alternatively, we could rework Morsmall to provide two ASTs, one with and one without locations; this should be easy to do with a well-made functor.Edit: Introduce a JSON serialisation that ignores locations #32Currently, in CI, we get the logging output of the tests runner, but this does not include the artifacts. We should upload them to allow inspection.Edit: CI should update the test artifacts #33