HIGH PRIORITY - Attach images to prompts #332

atrokhym · 2024-11-19T01:13:15Z

chrismahoney · 2024-11-19T07:36:06Z

Could you please post a video of how the interface works? This is a major feature involving vision, so it may have to be prioritized against the roadmap in the coming days. Thanks for the submission!

wonderwhy-er · 2024-11-19T08:34:32Z

We also have many models and providers, probably we need to disable such features when untested provider/model are used

pjmartorell · 2024-11-19T12:05:04Z

app/components/chat/BaseChat.tsx

+    messages,
+    children,  // Add this
+  }, ref) => {
+    console.log(provider);


this should be removed

pjmartorell · 2024-11-19T12:09:44Z

app/components/chat/UserMessage.tsx

+// function sanitizeUserMessage(content: string) {
+//   return content.replace(modificationsRegex, '').replace(MODEL_REGEX, 'Using: $1').replace(PROVIDER_REGEX, ' ($1)\n\n').trim();
+// }


this commented block should be removed

pjmartorell · 2024-11-19T12:11:16Z

app/lib/.server/llm/stream-text.ts

  // Extract model
-  const modelMatch = message.content.match(MODEL_REGEX);
+  // const modelMatch = message.content.match(MODEL_REGEX);


this comment should be removed

pjmartorell · 2024-11-19T12:11:27Z

app/lib/.server/llm/stream-text.ts

  const model = modelMatch ? modelMatch[1] : DEFAULT_MODEL;

  // Extract provider
-  const providerMatch = message.content.match(PROVIDER_REGEX);
+  // const providerMatch = message.content.match(PROVIDER_REGEX);


this comment should be removed

pjmartorell · 2024-11-19T12:19:53Z

app/lib/.server/llm/stream-text.ts

+      if (item.type === 'text') {
+        return {
+          type: 'text',
+          text: item.text?.replace(/\[Model:.*?\]\n\n/, '').replace(/\[Provider:.*?\]\n\n/, '')


these regexes are being repeated multiple times, can you use MODEL_REGEX and PROVIDER_REGEX or add them to constants.ts?

pjmartorell · 2024-11-19T12:21:03Z

app/routes/api.chat.ts

+    // console.log('=== API CHAT LOGGING START ===');
+    // console.log('StreamText:', JSON.stringify({
+    //   messages,
+    //   result,
+    // }, null, 2));
+    // console.log('=== API CHAT LOGGING END ===');
+


these comments should be removed

pjmartorell · 2024-11-19T12:38:50Z

package.json

@@ -73,6 +73,7 @@
    "jose": "^5.6.3",
    "js-cookie": "^3.0.5",
    "jszip": "^3.10.1",
+    "lucide-react": "^0.460.0",


this package is not needed and should be removed

pjmartorell · 2024-11-19T12:39:08Z

pnpm-lock.yaml

+  [email protected]([email protected]):
+    dependencies:
+      react: 18.3.1
+


it should be removed

pjmartorell · 2024-11-19T12:51:10Z

app/components/workbench/EditorPanel.tsx

@@ -204,7 +203,7 @@ export const EditorPanel = memo(
                  const isActive = activeTerminal === index;

                  return (
-                    <React.Fragment key={index}>


what is the reason of removing the index key?

Removing that key will throw an error, which is why it's a React.Fragment instead of <></> - please revert

pjmartorell · 2024-11-19T12:57:38Z

app/components/chat/UserMessage.tsx

+  const textContent = Array.isArray(sanitizedContent) 
+    ? sanitizedContent.find(item => item.type === 'text')?.text || ''
+    : sanitizedContent;


can this be merged/inserted inside sanitizeUserMessage function? otherwise you are unnecessarily looping twice over the contents

pjmartorell · 2024-11-19T13:54:54Z

We also have many models and providers, probably we need to disable such features when untested provider/model are used

The upload button could be only available for those models with vision capabilities and frozen/disabled for the others. The dynamic LLMs can be fetched from the OpenRouter API and filter those which have "modality": "text+image->text". The ones that are hardcoded can be flagged in the constants.ts

coleam00 · 2024-11-19T21:42:31Z

@atrokhym Thank you so much for this, I hope we can get it merged in soon! I appreciate your reviews a ton too @pjmartorell, fantastic!

atrokhym · 2024-11-20T01:45:20Z

@pjmartorell
thank you for doing my PR review.
i think i incorporated changes you requested. pls take a look
thanks a lot!

coleam00 · 2024-11-22T00:54:36Z

@atrokhym Thank you! Let me know if you can get around to reviewing again @pjmartorell!

atrokhym · 2024-11-22T02:21:52Z

@atrokhym Thank you! Let me know if you can get around to reviewing again @pjmartorell!
@coleam00 -i did run though those issues @pjmartorell noted.
i implemented all of them and ping him to review again. there are few commits after that.
also - should mention - i might missing something about process like who do what, notifications, etc...
so pls correct or point me in right direction.
this is my first git hub public PR :-)

rxyshww · 2024-11-25T05:15:51Z

This function is really great! May I ask when the merger will take place?

coleam00 · 2024-11-27T21:10:36Z

@atrokhym Would you say this is all ready to go? I can review this within the next couple of days too!

atrokhym · 2024-11-27T22:49:01Z

@atrokhym Would you say this is all ready to go? I can review this within the next couple of days too!

it was ready for merge couple of days back...but now more conflicts from main branch are coming...so i need to resolve them first...will do ASAP

coleam00 · 2024-11-27T23:08:54Z

Sounds good, thank you so much @atrokhym! I would love to showcase this for my update video on Sunday!

coleam00 · 2024-11-30T01:42:45Z

@atrokhym This is looking phenomenal!

There are a lot of merge conflicts with main right now - could you resolve those/rebase your branch on main?

Also I have a couple of suggestions to really make this PR shine:

The "X" after you upload an image has a half circle that makes it look like the image is still uploading.
Could you include a preview of the image in the chat messages so when you look at the chat history you can see the images that were uploaded?

Thank you for all your work on this!

atrokhym · 2024-11-30T03:12:24Z

@coleam00 - could you do review, please?

coleam00 · 2024-11-30T17:35:07Z

Looks good @atrokhym, thank you for fixing the conflicts! Did you get a chance to see my couple of suggestions as well?

atrokhym · 2024-11-30T18:38:27Z

Looks good @atrokhym, thank you for fixing the conflicts! Did you get a chance to see my couple of suggestions as well?

yes and i think item-1 looks much better now

for item-2 - as of now i don't know to do it....i would need to do some research...

atrokhym added 2 commits November 18, 2024 19:55

image-upload

e78a5b0

add module lucide-react

32f758b

atrokhym changed the title ~~image-upload~~ HIGH PRIORITY - Attach images to prompts Nov 19, 2024

chrismahoney added enhancement New feature or request question Further information is requested labels Nov 19, 2024

pjmartorell suggested changes Nov 19, 2024

View reviewed changes

atrokhym added 2 commits November 19, 2024 20:37

Merge remote-tracking branch 'upstream/main'

4b236e9

changing based on PR review

fe3ea80

fixes for PR coleam00#332

76713c2

atrokhym requested a review from pjmartorell November 20, 2024 23:00

atrokhym added 3 commits November 20, 2024 19:35

.

302cd28

model pickup

937ba7e

picking right model

df94e66

atrokhym added 2 commits November 21, 2024 23:31

Merge remote-tracking branch 'upstream/main'

70d14df

merge with upstream

0741610

atrokhym requested a review from chrismahoney November 22, 2024 04:34

upload new files

809b54e

merge with upstream/main

7cdb56a

adjusting spaces for X button in file-preview

ccaa67b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HIGH PRIORITY - Attach images to prompts #332

HIGH PRIORITY - Attach images to prompts #332

atrokhym commented Nov 19, 2024

chrismahoney commented Nov 19, 2024

wonderwhy-er commented Nov 19, 2024

pjmartorell Nov 19, 2024

pjmartorell Nov 19, 2024

pjmartorell Nov 19, 2024

pjmartorell Nov 19, 2024

pjmartorell Nov 19, 2024

pjmartorell Nov 19, 2024

pjmartorell Nov 19, 2024

pjmartorell Nov 19, 2024

pjmartorell Nov 19, 2024

chrismahoney Nov 19, 2024 •

edited

Loading

pjmartorell Nov 19, 2024

pjmartorell commented Nov 19, 2024

coleam00 commented Nov 19, 2024

atrokhym commented Nov 20, 2024

coleam00 commented Nov 22, 2024

atrokhym commented Nov 22, 2024

rxyshww commented Nov 25, 2024

coleam00 commented Nov 27, 2024

atrokhym commented Nov 27, 2024

coleam00 commented Nov 27, 2024

coleam00 commented Nov 30, 2024

atrokhym commented Nov 30, 2024

coleam00 commented Nov 30, 2024

atrokhym commented Nov 30, 2024

HIGH PRIORITY - Attach images to prompts #332

Are you sure you want to change the base?

HIGH PRIORITY - Attach images to prompts #332

Conversation

atrokhym commented Nov 19, 2024

chrismahoney commented Nov 19, 2024

wonderwhy-er commented Nov 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrismahoney Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjmartorell commented Nov 19, 2024

coleam00 commented Nov 19, 2024

atrokhym commented Nov 20, 2024

coleam00 commented Nov 22, 2024

atrokhym commented Nov 22, 2024

rxyshww commented Nov 25, 2024

coleam00 commented Nov 27, 2024

atrokhym commented Nov 27, 2024

coleam00 commented Nov 27, 2024

coleam00 commented Nov 30, 2024

atrokhym commented Nov 30, 2024

coleam00 commented Nov 30, 2024

atrokhym commented Nov 30, 2024

chrismahoney Nov 19, 2024 •

edited

Loading