Change to return of getBucketLocation and binder mappings in the Modu…

…leConfig.
coldbox-modules · Sep 20, 2023 · 49a12f6 · 49a12f6
1 parent bdcfcd3
commit 49a12f6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/ModuleConfig.cfc b/ModuleConfig.cfc
@@ -88,9 +88,12 @@ component {
 			name  = "urlStyle",
 			value = variables.settings.urlStyle
 			);
-		binder.map( "Sv4Util@s3sdk" ).to( "#moduleMapping#.models.AmazonS3" );
+		//This change might be based on ignorance but it didn't look correct. 
+		//binder.map( "Sv4Util@s3sdk" ).to( "#moduleMapping#.models.AmazonS3" );
+		binder.map( "Sv4Util@s3sdk" ).to( "#moduleMapping#.models.Sv4Util" );
 
-		binder.map( "Sv2Util@s3sdk" ).to( "#moduleMapping#.models.AmazonS3" );
+		//binder.map( "Sv2Util@s3sdk" ).to( "#moduleMapping#.models.AmazonS3" );
+		binder.map( "Sv2Util@s3sdk" ).to( "#moduleMapping#.models.Sv2Util" );
 	}
 
 

diff --git a/models/AmazonS3.cfc b/models/AmazonS3.cfc
@@ -337,12 +337,12 @@ component accessors="true" singleton {
 		if ( results.error ) {
 			throw( message = "Error making Amazon REST Call", detail = results.message );
 		}
-
-		if ( len( results.response.LocationConstraint.XMLText ) ) {
+		//Should this return whatever comes from AWS? It seems like hardcoding a potentially wrong answer is not a good idea. 
+		//if ( len( results.response.LocationConstraint.XMLText ) ) {
 			return results.response.LocationConstraint.XMLText;
-		}
+		//}
 
-		return "US";
+		//return "US";
 	}
 
 	/**