Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styling for Combobox, Dropdown and Popover [MDS-972] #2540

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dkireev
Copy link
Collaborator

@dkireev dkireev commented Feb 7, 2024

  1. Updated Tailwind to the latest
  2. Removed LongNameOptions from Combobox examples
  3. Removed menuWidth for Combobox.Options and Dropdown.Options from docs
  4. Updated tests for Carousel as it uses MenuItem
  5. Updated tests for Combobox, Dropdown, MenuItem, and Popover
  6. Reviewed all Combobox, Dropdown, and Popover examples
  7. Updated styles for Combobox.Options and Dropdown.Options
  8. Changed Combobox.Option and Dropdown.Option from span to li as it's wrapped with ul
  9. Marked as deprecated prop menuWidth for Combobox.Options and Dropdown.Options
  10. Improved styling for MenuItem, Popover, and Options

@dkireev dkireev requested a review from a team as a code owner February 7, 2024 14:52
Copy link

changeset-bot bot commented Feb 7, 2024

⚠️ No Changeset found

Latest commit: 9b62693

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant