-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Don't Merge Yet] Add support for dual reads #51
Open
ThatHurleyGuy
wants to merge
14
commits into
coinbase:master
Choose a base branch
from
ThatHurleyGuy:sean-hurley/dual-reads-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Don't Merge Yet] Add support for dual reads #51
ThatHurleyGuy
wants to merge
14
commits into
coinbase:master
from
ThatHurleyGuy:sean-hurley/dual-reads-updates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatHurleyGuy
changed the title
Add support for dual reads
[Don't Merge Yet] Add support for dual reads
May 31, 2022
…ing for when queries fail on the secondary
ThatHurleyGuy
force-pushed
the
sean-hurley/dual-reads-updates
branch
from
May 31, 2022 16:05
4c3c731
to
65c87e1
Compare
ThatHurleyGuy
force-pushed
the
sean-hurley/dual-reads-updates
branch
from
May 31, 2022 16:07
65c87e1
to
84b556e
Compare
ThatHurleyGuy
force-pushed
the
sean-hurley/dual-reads-updates
branch
from
May 31, 2022 16:10
84b556e
to
d0bde54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #48 (I'm taking over the debugging for this)
Still in the process of debugging, and this PR is not ready to merge yet. Tests are currently failing and will be updated.