Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Apple App Tracking Transparency (ATT) Configuration #8

Merged
merged 1 commit into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,18 @@ It can manage four different types of first-party client side cookies:

## Getting Started

This repo uses a yarn workspace. To get started, run:
This repo uses a yarn workspace. To get started with the example app:

```shell
# Install Dependencies
yarn install
cd /path/to/coinbase/cb-cookie-manager

# To lint all files
yarn lint
# Install Dependencies and Build Packages
yarn install
yarn build

# To run tests
yarn test
# Run Example App
cd /path/to/coinbase/cb-cookie-manager/example/app
yarn dev
```

## Packages
Expand Down
2 changes: 1 addition & 1 deletion apps/example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"dependencies": {
"@coinbase/cookie-banner": "1.0.3",
"@coinbase/cookie-manager": "1.1.1",
"@coinbase/cookie-manager": "1.1.2",
"next": "14.0.0",
"react": "^18",
"react-dom": "^18"
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"test": "yarn workspaces run test"
},
"workspaces": [
"packages/*",
"packages/cookie-manager",
"packages/cookie-banner",
"apps/example"
],
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/cookie-banner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"react-dom": "^18.1.0"
},
"dependencies": {
"@coinbase/cookie-manager": "1.1.1",
"@coinbase/cookie-manager": "1.1.2",
"react-intl": "^6.5.1",
"styled-components": "^5.3.6"
}
Expand Down
6 changes: 6 additions & 0 deletions packages/cookie-manager/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.1.2 (02/26/2024)

#### 🚀 Updates

- Remove check for `is_mobile_app` from URL parameter from a WebView and use `app_tracking_transparency_enabled` to persist `is_mobile_app` cookie. This implementation is used to honor the Apple Do Not Track (DNT) configuration from a users' device instead of disabling cookies solely because the request is coming from a mobile device.

## 1.1.1 (01/05/2024)

#### Bug
Expand Down
4 changes: 1 addition & 3 deletions packages/cookie-manager/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@coinbase/cookie-manager",
"version": "1.1.1",
"version": "1.1.2",
"description": "Coinbase Cookie Manager",
"main": "dist/index.js",
"license": "Apache-2.0",
Expand All @@ -26,8 +26,6 @@
"wrap-ansi-cjs": "7.0.0"
},
"dependencies": {
"@coinbase/cookie-banner": "1.0.1",
"@coinbase/cookie-manager": "1.1.0",
"js-cookie": "^3.0.5"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ import {
import { useCookie } from '../CookieContext';
import { useTrackingManager } from '../TrackingManagerContext';
import { Region, TrackingCategory, TrackingPreference } from '../types';
import { getIsMobileAppFromQueryParams } from '../utils/persistMobileAppPreferences';
import { getAppTrackingTransparencyFromQueryParams } from '../utils/persistMobileAppPreferences';

export const useSavedTrackingPreferenceFromMobileApp = (): TrackingPreference | undefined => {
const { region } = useTrackingManager();

const [isMobileAppFromCookie] = useCookie(IS_MOBILE_APP);

const isMobileAppFromQueryParams = useMemo(() => getIsMobileAppFromQueryParams(), []);
const isMobileAppFromQueryParams = useMemo(() => getAppTrackingTransparencyFromQueryParams(), []);

const isMobileApp = isMobileAppFromCookie || isMobileAppFromQueryParams;

Expand Down
2 changes: 1 addition & 1 deletion packages/cookie-manager/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ export { default as getDefaultTrackingPreference } from './utils/getDefaultTrack
export { getDomainWithoutSubdomain } from './utils/getDomain';
export { default as isOptOut } from './utils/isOptOut';
export {
getIsMobileAppFromQueryParams,
getAppTrackingTransparencyFromQueryParams,
persistMobileAppPreferences,
} from './utils/persistMobileAppPreferences';
18 changes: 9 additions & 9 deletions packages/cookie-manager/src/utils/persistMobileAppPreferences.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
/*
* The purpose here is to allow the iOS/Android app to send a is_mobile_app=true
* parameter that should indicate to the web surfaces not to show the
* cookie banner
*
* From the iOS app, the `Do Not Track` preference from the app should be read and
* a `app_tracking_transparency_enabled=true` URL parameter is set to indicate the
* app tracking pereferences. The setting is then persisted in a cookie to honor the
* user preference for when a WebView is opened from within the mobile app.
*/

import { IS_MOBILE_APP } from '../constants';
import { getDomainWithoutSubdomain } from './getDomain';

export function persistMobileAppPreferences() {
try {
const isMobileApp = getIsMobileAppFromQueryParams();
const isMobileApp = getAppTrackingTransparencyFromQueryParams();
if (isMobileApp) {
document.cookie = `${IS_MOBILE_APP}=true; domain=${getDomainWithoutSubdomain()}`;
}
Expand All @@ -19,12 +19,12 @@ export function persistMobileAppPreferences() {
}
}

export function getIsMobileAppFromQueryParams() {
export function getAppTrackingTransparencyFromQueryParams() {
try {
const params = new URLSearchParams(window.location.search);
const isWebView = params.get('webview') === 'true';
const isMobileApp = params.get(IS_MOBILE_APP) === 'true';
return Boolean(isWebView || isMobileApp);

const appTrackingTransparency = params.get('app_tracking_transparency_enabled') === 'true';
return Boolean(appTrackingTransparency);
} catch (e) {
// Ignore, we are not in a browser.
}
Expand Down
6 changes: 6 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1077,6 +1077,11 @@
resolved "https://registry.yarnpkg.com/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz#75a2e8b51cb758a7553d6804a5932d7aace75c39"
integrity sha512-0hYQ8SB4Db5zvZB4axdMHGwEaQjkZzFjQiN9LVYvIFB2nSUHW9tYpxWriPrWDASIxiaXax83REcLxuSdnGPZtw==

"@coinbase/[email protected]":
version "1.1.1"
dependencies:
js-cookie "^3.0.5"

"@cspotcode/source-map-support@^0.8.0":
version "0.8.1"
resolved "https://registry.yarnpkg.com/@cspotcode/source-map-support/-/source-map-support-0.8.1.tgz#00629c35a688e05a88b1cda684fb9d5e73f000a1"
Expand Down Expand Up @@ -6693,6 +6698,7 @@ which@^2.0.1:
isexe "^2.0.0"

[email protected], "wrap-ansi-cjs@npm:wrap-ansi@^7.0.0", wrap-ansi@^7.0.0:
name wrap-ansi
version "7.0.0"
resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43"
integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q==
Expand Down
Loading