Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Support retention durations #6

Merged
merged 7 commits into from
Dec 15, 2023
Merged

[feat] Support retention durations #6

merged 7 commits into from
Dec 15, 2023

Conversation

Sneh1999
Copy link
Contributor

@Sneh1999 Sneh1999 commented Dec 14, 2023 •
edited
Loading

What changed? Why?

  • Updated cookie config to include retention durations at both category and cookie levels.
  • Introduced an optional boolean field sessionCookie in cookie config to accommodate session cookies.
  • Implemented a setExpiryForCookie hook that adjusts the cookie's expiration in the following manner:
    • If the sessionCookie parameter is enabled, the expiry is set to session
    • If an expiry is specified at the cookie level, it takes precedence; otherwise, the expiry is derived from the category's expiration setting.

Notes to reviewers

How has it been tested?

  • Unit tests
  • Local testing

@Sneh1999 Sneh1999 changed the title [feat]Support retention durations [feat] Support retention durations Dec 14, 2023
@Sneh1999 Sneh1999 merged commit 5a07158 into main Dec 15, 2023
3 checks passed
@Sneh1999 Sneh1999 deleted the support-retention-durations branch December 15, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaostrom-cb joshuaostrom-cb joshuaostrom-cb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sneh1999 @joshuaostrom-cb