Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@coinbase/cookie-banner v1.0.4 #11

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

yangkenneth
Copy link
Contributor

@yangkenneth yangkenneth commented Mar 8, 2024

What changed? Why?

npm list @coinbase/cookie-banner
[email protected] /Users/yangkenneth/coinbase/cb-cookie-manager
└─┬ @coinbase/[email protected]
  └─┬ @coinbase/[email protected]
    ├── @coinbase/[email protected]
    └─┬ @coinbase/[email protected]
      └── @coinbase/[email protected] deduped

Notes to reviewers

How has it been tested?

  • Build Updated Release for @coinbase/cookie-banner Locally
  • Update Example App package.json to Local Path of @coinbase/cookie-banner and Install Dependencies with yarn.
  "dependencies": {
    "@coinbase/cookie-banner": "file:/path/to/cb-cookie-manager/packages/cookie-banner",
    "@coinbase/cookie-manager": "^1.1.2",
    "next": "14.0.0",
    "react": "^18",
    "react-dom": "^18"
  },

Screenshot 2024-03-08 at 2 58 51 PM

@cb-heimdall
Copy link

Review Error for joshuaostrom-cb @ 2024-03-11 19:35:16 UTC
User failed mfa authentication, see go/mfa-help

@yangkenneth yangkenneth merged commit 8361dfb into main Mar 11, 2024
5 checks passed
@yangkenneth yangkenneth deleted the yangkenneth/cookie-banner-dependency branch March 13, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants