cleanup

coinbase · Dec 15, 2023 · ff68691 · ff68691
1 parent f507a19
commit ff68691
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/packages/cookie-manager/CHANGELOG.md b/packages/cookie-manager/CHANGELOG.md
@@ -2,7 +2,11 @@
 
 ## 1.1.0 (12/14/2023)
 
-Support retention durations for Cookies in the config and category level
+- Updated cookie config to include retention durations at both category and cookie levels.
+- Introduced an optional boolean field `sessionCookie` in cookie config to accommodate session cookies.
+- Implemented a setExpiryForCookie hook that adjusts the cookie's expiration in the following manner:
+  - If the sessionCookie parameter is enabled, the expiry is set to session
+  - If an expiry is specified at the cookie level, it takes precedence; otherwise, the expiry is derived from the category's expiration setting.
 
 ## 1.0.0 (12/7/2023)
 

diff --git a/packages/cookie-manager/README.md b/packages/cookie-manager/README.md
@@ -74,7 +74,7 @@ export default {
         {
           id: 'locale',
           type: TrackerType.COOKIE,
-          expiry: new Date('2024-09-29T00:00:00.000Z'),
+          expiry: 10,
         },
       ],
     },
@@ -163,7 +163,7 @@ You need to specify the retention days for a category using the expiry key as fo
         {
           id: 'locale',
           type: TrackerType.COOKIE,
-          expiry: new Date('2024-09-29T00:00:00.000Z'),
+          expiry: 10,
         },
       ],
     }

diff --git a/packages/cookie-manager/src/constants.ts b/packages/cookie-manager/src/constants.ts
@@ -34,11 +34,3 @@ export const TRACKER_CATEGORIES: Array<TrackingCategory> = [
   TrackingCategory.PERFORMANCE,
   TrackingCategory.TARGETING,
 ];
-
-export const CATEGORY_EXPIRATION_DAYS: Record<TrackingCategory, number> = {
-  [TrackingCategory.NECESSARY]: 365,
-  [TrackingCategory.FUNCTIONAL]: 365,
-  [TrackingCategory.PERFORMANCE]: 365,
-  [TrackingCategory.TARGETING]: 365,
-  [TrackingCategory.DELETE_IF_SEEN]: 0,
-};