Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): add extra checks to test workflow #168

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

HeyZoos
Copy link
Contributor

@HeyZoos HeyZoos commented Oct 3, 2024

  • Add Rust checks after the frontend is built
  • Remove updater configuration so that forks build (should be ok since the publish workflow brings the update signing back)
  • Run the formatter
  • Set all tauri-plugin-* dependencies to v1 instead of dev (fixes "tauri-plugin-{{name}}" issue)

Closes #74

@@ -81,6 +81,18 @@ jobs:
- name: Yarn install FE dependencies
run: yarn --prefer-offline --frozen-lockfile --network-timeout 1000000 install

- name: Cargo Check
run: cargo check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the failed action run, we might need to do some code changes too 🤔

@HeyZoos HeyZoos marked this pull request as ready for review October 24, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CI/CD with check fmt and clippy
2 participants