Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Freshsales] Refactoring/Improvements #32

Merged
merged 3 commits into from
Jan 11, 2024
Merged

[Freshsales] Refactoring/Improvements #32

merged 3 commits into from
Jan 11, 2024

Conversation

tianjing-li
Copy link
Collaborator

What's being changed:

Freshsales connector:

  • Cleans up provider code, moving client-specific logic into a client.py file with a FreshsalesClient class. This class takes care of all request setup and handling
  • Adds search limit env variable, and reference in README
  • Adds serialization for search results
  • Removes unneeded constants

How did you test this change (include any code snippets, API requests, screenshots, or gifs):

Tested locally

@tianjing-li tianjing-li requested a review from a team as a code owner January 10, 2024 16:22
walterbm-cohere
walterbm-cohere approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@walterbm-cohere walterbm-cohere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

freshsales/README.md Outdated Show resolved Hide resolved
freshsales/provider/client.py Outdated Show resolved Hide resolved
EugeneLightsOn
EugeneLightsOn approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@EugeneLightsOn EugeneLightsOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tianjing-li tianjing-li merged commit e307b03 into main Jan 11, 2024
2 checks passed
@tianjing-li tianjing-li deleted the freshsales-improvements branch January 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneLightsOn EugeneLightsOn EugeneLightsOn approved these changes

@walterbm-cohere walterbm-cohere walterbm-cohere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianjing-li @walterbm-cohere @EugeneLightsOn