[HackerNews] Strip HTML tags and add cache #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackernews/provider/provider.py
Outdated
Comment on lines
45
to
46
| # Fix HTML tags that can break request response for Coral | ||
| stripped_result["text"] = stripped_result["text"].replace('"', "'") |
There was a problem hiding this comment.
@tianjing-li Do you have examples of how this is changes the connector's JSON responses? Assuming the response was valid JSON maybe that points to a bug in the UI and not in this specific connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
Resolves #24
How did you test this change (include any code snippets, API requests, screenshots, or gifs):