Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elasticsearch] Improvements #21

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[Elasticsearch] Improvements #21

merged 2 commits into from
Dec 19, 2023

Conversation

tianjing-li
Copy link
Collaborator

What's being changed:

  • Adds client.py wrapper implementation
  • Adds more explicit error handling for env variables
  • Clarifies README

How did you test this change (include any code snippets, API requests, screenshots, or gifs):

Tested locally

@tianjing-li tianjing-li requested a review from a team as a code owner December 18, 2023 19:34
daniel-cohere
daniel-cohere approved these changes Dec 18, 2023
View reviewed changes
elastic/provider/client.py Show resolved Hide resolved
@tianjing-li tianjing-li merged commit 7c4089c into main Dec 19, 2023
2 checks passed
@tianjing-li tianjing-li deleted the elastic-improvements branch December 19, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-cohere daniel-cohere daniel-cohere approved these changes

@EugeneLightsOn EugeneLightsOn Awaiting requested review from EugeneLightsOn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianjing-li @daniel-cohere