Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements: Sharepoint OAuth, docs improvements, code clarifications #17

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

tianjing-li
Copy link
Collaborator

@tianjing-li tianjing-li commented Dec 13, 2023

What's being changed:

Sharepoint connector:

  • Adds OAuth as an auth type (keeps existing application auth)
  • Improves README, documents both types of auth
  • Clarifies client and provider code - notably removing list items (drive items take care of files, so this was unnecessary)

How did you test this change (include any code snippets, API requests, screenshots, or gifs):

  • Tested on local setup, and registering in prod for application/oauth

image

@tianjing-li tianjing-li requested a review from a team as a code owner December 13, 2023 16:59
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tianjing-li
❌ walterbm-cohere
You have signed the CLA already but the status is still pending? Let us recheck it.

…ctors into sharepoint-oauth

# Conflicts:
#	README.md
#	cockroach/dev/load_data.py
#	confluence/dev/load_data.py
#	elastic/docker-compose.yml
#	gdrive/README.md
#	jira/dev/load_data.py
#	mongodb/dev/load_data.py
#	mongodb/docker-compose.yml
#	opensearch/docker-compose.yml
#	pinecone/dev/generate_embeddings.py
#	postgres/docker-compose.yml
#	redis/dev/load_data.py
#	redis/docker-compose.yml
#	sharepoint/.env-template
#	sharepoint/README.md
#	sharepoint/provider/client.py
#	sharepoint/provider/provider.py
#	sharepoint/provider/unstructured.py
#	snowflake/README.md
#	solr/docker-compose.yml
#	vespa/docker-compose.yml
#	weaviate/docker-compose.yml
#	wordpress/dev/load_data.py
Copy link
Collaborator

@EugeneLightsOn EugeneLightsOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just couple of comments

sharepoint/README.md Outdated Show resolved Hide resolved
sharepoint/provider/client.py Outdated Show resolved Hide resolved
sharepoint/provider/client.py Show resolved Hide resolved
sharepoint/provider/provider.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@EugeneLightsOn EugeneLightsOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tianjing-li tianjing-li merged commit 6aa1ba0 into main Dec 19, 2023
2 checks passed
@tianjing-li tianjing-li deleted the sharepoint-oauth branch December 19, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants