Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropbox] Add Unstructured file decoding to Dropbox #11

Merged
merged 4 commits into from
Dec 21, 2023
Merged

[Dropbox] Add Unstructured file decoding to Dropbox #11

merged 4 commits into from
Dec 21, 2023

Conversation

tianjing-li
Copy link
Collaborator

What's being changed:

  • Adds unstructured client to Dropbox connector, with async requests
  • Adds serialization for Dropbox results, gathers files for batch Unstructured requests

How did you test this change (include any code snippets, API requests, screenshots, or gifs):

  • Tested the content being properly decoded locally, batch async requests also work

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tianjing-li tianjing-li changed the title Add unstructured code to Dropbox Add Unstructured file decoding to Dropbox Dec 6, 2023
@walterbm-cohere walterbm-cohere changed the title Add Unstructured file decoding to Dropbox [Dropbox] Add Unstructured file decoding to Dropbox Dec 6, 2023
walterbm-cohere
walterbm-cohere reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@walterbm-cohere walterbm-cohere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few initial comments. Let me know what you think!

dropbox/provider/unstructured.py Outdated Show resolved Hide resolved
dropbox/provider/unstructured.py Outdated Show resolved Hide resolved
dropbox/provider/provider.py Show resolved Hide resolved
dropbox/provider/unstructured.py Outdated Show resolved Hide resolved
@tianjing-li tianjing-li requested a review from a team as a code owner December 11, 2023 20:15
EugeneLightsOn
EugeneLightsOn reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@EugeneLightsOn EugeneLightsOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one comment

dropbox/.env-template Outdated Show resolved Hide resolved
daniel-cohere
daniel-cohere approved these changes Dec 19, 2023
View reviewed changes
dropbox/.env-template Show resolved Hide resolved
@tianjing-li tianjing-li merged commit 2e24032 into main Dec 21, 2023
2 checks passed
@tianjing-li tianjing-li deleted the dropbox-decode branch December 21, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneLightsOn EugeneLightsOn EugeneLightsOn left review comments

@walterbm-cohere walterbm-cohere walterbm-cohere left review comments

@daniel-cohere daniel-cohere daniel-cohere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tianjing-li @CLAassistant @daniel-cohere @walterbm-cohere @EugeneLightsOn