Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAG Guide: Comment out set_css logic that breaks for Jupyter notebooks #161

Merged
merged 2 commits into from
May 6, 2024

Conversation

rossdanlm
Copy link

@rossdanlm rossdanlm commented Apr 25, 2024

RAG Guide: Comment out set_css logic that breaks for Jupyter notebooks

I noticed that this was breaking for when I was running this in Jupyter notebooks. I also noticed we had comments in the notebook saying # Uncomment for Google Colab to ... so figured we could do the same here. If you don't like it, no worries

Test Plan

Before it wasn't working, and we got these errors

Error in callback <function set_css at 0x33e33d260> (for pre_run_cell), with arguments args (<ExecutionInfo object at 33e35b110, raw_cell="raw_documents = [
    {
        "title": "Text Emb.." store_history=True silent=False shell_futures=True cell_id=vscode-notebook-cell:/Users/rossdancraig/Projects/cohere-notebooks/notebooks/guides/RAG_with_Chat_Embed_and_Rerank_via_Pinecone.ipynb#X13sZmlsZQ%3D%3D>,),kwargs {}:

{
	"name": "TypeError",
	"message": "set_css() takes 0 positional arguments but 1 was given",
	"stack": "---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
TypeError: set_css() takes 0 positional arguments but 1 was given"
}

Now it works!


Stack created with Sapling. Best reviewed with ReviewStack.

Rossdan Craig [email protected] added 2 commits April 25, 2024 16:05
… from .env file

Nice convenience function, don't need to acecpt if you don't like it


## Test Plan
Notebook runs if you define API keys in an .env file
I noticed that this was breaking for when I was running this in Jupyter notebooks. I also noticed we had comments in the notebook saying `# Uncomment for Google Colab to ...` so figured we could do the same here. If you don't like it, no worries

## Test Plan
Before it wasn't working, and we got these errors
```
Error in callback <function set_css at 0x33e33d260> (for pre_run_cell), with arguments args (<ExecutionInfo object at 33e35b110, raw_cell="raw_documents = [
    {
        "title": "Text Emb.." store_history=True silent=False shell_futures=True cell_id=vscode-notebook-cell:/Users/rossdancraig/Projects/cohere-notebooks/notebooks/guides/RAG_with_Chat_Embed_and_Rerank_via_Pinecone.ipynb#X13sZmlsZQ%3D%3D>,),kwargs {}:

```

```
{
	"name": "TypeError",
	"message": "set_css() takes 0 positional arguments but 1 was given",
	"stack": "---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
TypeError: set_css() takes 0 positional arguments but 1 was given"
}
```

Now it works!
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rossdan Craig [email protected] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mrmer1
Copy link
Contributor

mrmer1 commented May 6, 2024

@rossdanlm Thanks for highlighting this! Merging.

@mrmer1 mrmer1 merged commit 2b65c13 into cohere-ai:main May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants