Throw when trying to rerank with v1 #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkozakov
approved these changes
Dec 4, 2024
| @@ -25,6 +25,8 @@ def __init__( | |||
| timeout=timeout, | |||
| ) | |||
|
|
|||
| def rerank(self, *, query, documents, model = ..., top_n = ..., rank_fields = ..., return_documents = ..., max_chunks_per_doc = ..., request_options = None): | |||
| raise NotImplementedError("Please use cohere.BedrockClientV2 instead: method rerank is not available in the v1 client, cohere.BedrockClient.") | |||
There was a problem hiding this comment.
this makes it sound like we haven't added support in the V1 sdk yet. should we change the message t o say
Suggested change
| raise NotImplementedError("Please use cohere.BedrockClientV2 instead: method rerank is not available in the v1 client, cohere.BedrockClient.") | |
| raise NotImplementedError("Rerank API on Bedrock is not supported with cohere.BedrockClient for this model. Please use cohere.BedrockClientV2 instead.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #613
The PR introduces a new function,
rerank, to theBedrockClientclass. This function is not available in the v1 client,cohere.BedrockClient, and users are advised to usecohere.BedrockClientV2instead.rerank, is added to theBedrockClientclass.NotImplementedErrorto inform users that it is not available in the v1 client,cohere.BedrockClient.cohere.BedrockClientV2instead.