Add asset_type field to the assets structures #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaxter-cohere
previously approved these changes
Dec 10, 2024
javier-cohere
previously approved these changes
Dec 10, 2024
|
Approving to unblock: tests failing though |
artemiyatcohere
dismissed stale reviews from javier-cohere and dbaxter-cohere
via
7357fb9
artemiyatcohere
force-pushed
the
artemiy/add-asset-type
branch
from
2bddf31 to
7357fb9
Compare
javier-cohere
approved these changes
Dec 11, 2024
artemiyatcohere
added a commit
that referenced
this pull request
Dec 13, 2024
This reverts commit 3a5d494.
artemiyatcohere
added a commit
that referenced
this pull request
Dec 13, 2024
luca-cohere
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
asset_typefield to the assets to make it possible to identify what the assets contain.