Move modules under "cohere.compass" + More refactoring #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move all modules under "cohere.compass". - Remove `tqdm` from dependencies; we are not using it. - Added `pyright` type checking to pre-commit. - Changed pyright checking mode from `basic`, which, as the name suggests, is basic and didn't catch some errors to `strict` to ensure we catch as many errors as possible at coding time rather than run time. - Updated README.md to have pyright certification at the top ;-)
- `python-version` matrix values should be strings. - Renamed `formatting.yml` to `pre-commit-checks.yml` since we are not just doing formatting checks now, but running multiple rules. - Removed `typecheck.yml` since now we execute pyright checks using pre-commit, so already covered by the pre-commit workflow.
artemiyatcohere
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tqdmfrom dependencies; we are not using it.pyrighttype checking to pre-commit.basic, which, as the name suggests, is basic and didn't catch some errors tostrictto ensure we catch as many errors as possible at coding time rather than run time.[3.9, 4.0).