Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for some minor positioning annoyances #1470

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Conversation

Oaphi
Copy link
Member

@Oaphi Oaphi commented Dec 7, 2024

This is a minor PR addressing positioning annoyances that drive me mad every time I see them.

Filters "delete" button before the change:
2024-12-07_21-57
And after:
2024-12-07_22-33

Search OAuth apps button before the change:
qpixel-search-oauth-btn-before
And after (the icon is changed from textual to icon-based to align with every other search input):
qpixel-search-oauth-btn-after

@Oaphi Oaphi requested a review from a team December 7, 2024 19:38
@Oaphi Oaphi added the area: html/css/js Changes to front-end code label Dec 7, 2024
@Oaphi Oaphi changed the title 0valt/positioning Fixes for some minor positioning annoyances Dec 7, 2024
@cellio
Copy link
Member

cellio commented Dec 8, 2024

LGTM, but one question: where is that OAuth page on the site? (How do I navigate to it?) I don't recognize that, and I didn't find it on a quick walk through my profile tabs.

@Oaphi
Copy link
Member Author

Oaphi commented Dec 8, 2024

#1470 (comment)

@cellio from what I understand, they are unlinked, at least for now (I may be mistaken), but can be navigated to via a direct URL (just substitute micro_auth with oauth in routes definitions). Even if they are unliked for jow, we will need them for a proper API, so it amde sense to me to fix them while I am at it.

@cellio
Copy link
Member

cellio commented Dec 8, 2024

I totally agree on fixing them; I was just trying to figure out why I'd never seen that. :-)

@@ -17,14 +17,6 @@ select.form-element {

@media screen and (min-width: $screen-md) {
flex-direction: row;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the effect of removing these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cellio no effect that I managed to notice while checking other than the positioning of the "delete" button being fixed. All the other instances have CSS that make these rules redundant.

@ArtOfCode- ArtOfCode- merged commit b5af462 into develop Dec 8, 2024
7 checks passed
@ArtOfCode- ArtOfCode- deleted the 0valt/positioning branch December 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: html/css/js Changes to front-end code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants