-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for some minor positioning annoyances #1470
Conversation
LGTM, but one question: where is that OAuth page on the site? (How do I navigate to it?) I don't recognize that, and I didn't find it on a quick walk through my profile tabs. |
@cellio from what I understand, they are unlinked, at least for now (I may be mistaken), but can be navigated to via a direct URL (just substitute |
I totally agree on fixing them; I was just trying to figure out why I'd never seen that. :-) |
@@ -17,14 +17,6 @@ select.form-element { | |||
|
|||
@media screen and (min-width: $screen-md) { | |||
flex-direction: row; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the effect of removing these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cellio no effect that I managed to notice while checking other than the positioning of the "delete" button being fixed. All the other instances have CSS that make these rules redundant.
This is a minor PR addressing positioning annoyances that drive me mad every time I see them.
Filters "delete" button before the change:
And after:
Search OAuth apps button before the change:
And after (the icon is changed from textual to icon-based to align with every other search input):