added guidance on score values #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a little guidance about scores after seeing some user confusion.
I tried to make "min score" and "max score" links, but those were clickable before and triggered the form field, and that behavior overrides the link.
I also tried to move the help link closer to the form fields, to more clearly "go with" the previous row, but couldn't figure out how. I tried adding an extra layer of form grouping to include that row plus this link, but it laid out as one row with (now) five elements. We have a design framework, so I don't think resorting to direct HTML hackery is the right way to go about it. I think having the link is better than not having it, and having it in a slightly different place would be better than this.
Update: here's a screenshot: