-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable email senders #1181
Conversation
Set subject as required and add an are you sure before actually sending the emails.
Also, it is now required to be both a global admin and a developer to email all users.
LGTM - will wait for ready-to-merge status :) |
@cellio I added you as reviewer not for the code, but because I think it would be good for you to review whether the default email addresses configured actually make sense. Note also that these are modifiable per community. |
@Taeir I think SupportReceiverEmail should probably be Another question for Art: do we need a separate support address for donations, or can everything involving donations come down to DonationSenderName and DonationSenderEmail? |
Email addresses can basically be whatever we like - support should be support@, yes, and donations are fine to all come from one address |
Previously, all email senders were hardcoded in the source to be
@codidact.com
/@codidact.org
email addresses. This changes those to be configurable.