Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable email senders #1181

Merged
merged 9 commits into from
Dec 3, 2023
Merged

Configurable email senders #1181

merged 9 commits into from
Dec 3, 2023

Conversation

Taeir
Copy link
Contributor

@Taeir Taeir commented Aug 17, 2023

Previously, all email senders were hardcoded in the source to be @codidact.com/@codidact.org email addresses. This changes those to be configurable.

  • Creates configuration for all the emails QPixel can send
  • Require both developer and global admin to send email to all users, rather than just developer.
  • Avoid accidental send all users email by adding more warnings and confirmation
  • Move buttons for email sending together in admin tools.
  • Change setting category from EmailSubscriptions to just Email.

Taeir added 5 commits August 17, 2023 23:09
Set subject as required and add an are you sure before actually sending
the emails.
Also, it is now required to be both a global admin and a developer to
email all users.
@cellio cellio requested a review from ArtOfCode- August 17, 2023 23:30
@ArtOfCode-
Copy link
Member

LGTM - will wait for ready-to-merge status :)

@Taeir Taeir requested review from ArtOfCode- and cellio November 12, 2023 15:14
@Taeir Taeir marked this pull request as ready for review November 12, 2023 15:14
@Taeir
Copy link
Contributor Author

Taeir commented Nov 12, 2023

@cellio I added you as reviewer not for the code, but because I think it would be good for you to review whether the default email addresses configured actually make sense. Note also that these are modifiable per community.

For reference, here are the settings:
image

@cellio
Copy link
Member

cellio commented Nov 12, 2023

@Taeir I think SupportReceiverEmail should probably be [email protected] rather than info, but @ArtOfCode- please confirm.

Another question for Art: do we need a separate support address for donations, or can everything involving donations come down to DonationSenderName and DonationSenderEmail?

@ArtOfCode-
Copy link
Member

Email addresses can basically be whatever we like - support should be support@, yes, and donations are fine to all come from one address

@Taeir Taeir self-assigned this Nov 14, 2023
@ArtOfCode- ArtOfCode- merged commit 010b7a2 into develop Dec 3, 2023
2 checks passed
@ArtOfCode- ArtOfCode- deleted the configurable-emails branch December 3, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants