tripled height of code blocks (issue #43) #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting a review from @ArtOfCode- because if this is accepted it's going to need to be propagated to QPixel and deployed anyway. |
|
I tested this with a live CSS modifier tool in a browser - if we make this change, it will have the intended effect after merge, and after someone makes a new NPM release of co-design, bumps the version fetched by our CDN (best keep all of these references up to sync: https://github.com/codidact/qpixel/search?q=co-design) and deploys the core app. |
|
@luap42 we implemented your suggestion; could you approve this PR? Thanks. |
sau226
approved these changes
Apr 14, 2022
ArtOfCode-
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code blocks currently show only 13 lines, which isn't enough. Discussion on the linked issue suggests 40 as a reasonable number. A comment from @luap42 (#43 (comment)) points to the line to change; it's measured in ems not lines, so I tripled it from 20 to 60, preferring the round number in the CSS to the round number of 40 lines.
I can't test this. Please review.