Dark theme #59
Closed
Dark theme #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make text color black for .notice
Blackish background don't show black text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #57 and, codidact/qpixel#565
Dark theme
Umm!
Code area (pre tag) and, user-card-meta's background is changed from cd.com/assets/stylesheets/application.scss That's why I didn't make changes to them in codidact.scss.button is-muted is-outlined is-active(activity tab) is from codidact.scss. But, when I was copy-pasting those code I forgot to change their color and, background-color. I will change check it again.Currently, I am using separated lines just to understand those code. In my last commit I will write them in a line (or, mix them).
Found a problem.... :
texts isn't white color in fields.. And, .notice .is-warning color is white.....(Maybe, now I can say that no more work is needed in CoDesign)(activity tab should be black (leaving it as it is for now))(Check following picture and, comment if you see any problem)New changes
Note : Diff is showing that I made changes to light theme also. Usually, I make changes to light theme. It's all over dark theme.
To test (If you are using Linux) : If you are using Chrome/Chromium than, run that following way
You won't face problem for Firefox. I am not sure of Vilvera and, some others (Safari etc). Read the thread to know why you are facing the problem.