[BUG FIX] Update the navigation panel in proposal route #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @AuraOfDivinity and @ksraj123 can we review this up? |
AuraOfDivinity
requested changes
Oct 3, 2020
There was a problem hiding this comment.
Thanks for the PR @varunks99 . Few concerns on my end.
- The background color of the navbar is not consistent. We still have the white color appearing over some portions. Please find the cause of this and fix it.
- The nav bar should take up the entire width of the navigation panel(Check and compare the implementation of this with the navbar implementation of the dashboard.)
Please let me know if you need further clarification.
Are you talking about the Jitsi Meet and Logout buttons?
Could you please elaborate on this a little? As I was not able to reproduce this issue. |
|
@varunks99 Please have a look at the parts I have highlighted in red and compare it with the nav panel on the following image. They should basically look similar.
Notice that the nav panel takes up the entire width and the background color of the navbar is consistent. |
Fix nav panel width and inconsistent background colour for proposal editor page
varunks99
force-pushed
the
GH-636_navigation_panel_fix
branch
from
2dbfea8 to
53943aa
Compare
|
@AuraOfDivinity, I fixed it now.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #636.
Bug description
The navigation bar on the left-hand side of the proposal related pages is not properly updated.
Root cause
The 'active' class for the navigation panel is defined by the respective props. The props passed for the proposal component was incorrect/incomplete.
Solution description
I added the state {org:true} in the ProposalEditor component and passed it as props to the navigation panel.
Now when clicking on the "propose an idea button", the "Organization" tab is highlighted and active as should be.
Screenshots
@AuraOfDivinity @jaskiratsingh2000