Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AndroidImplementation.java #3826

Closed
wants to merge 1 commit into from

Conversation

Eric-Chomba
Copy link
Contributor

Delete cached file after sharing it to prevent appending IMG_DATE_TIME to the file name when re-sharing it.

https://www.reddit.com/r/cn1/comments/1ed9ngf/share_api_appending_img_date_time_to_file_name/

Delete cached file after sharing it to prevent appending IMG_DATE_TIME to the file name when re-sharing it.

https://www.reddit.com/r/cn1/comments/1ed9ngf/share_api_appending_img_date_time_to_file_name/
@shai-almog
Copy link
Collaborator

@Eric-Chomba The reformatting to the file makes the change practically unreadable. I get the point of consistency but doing something like this would mean all prior changes would become useless.

The change itself seems fine. Can you commit a version with only that change?

@Eric-Chomba
Copy link
Contributor Author

Okay, create a new pull request

#3827

@shai-almog shai-almog closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants