This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Feat/add axios retry and better errors #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzpab
reviewed
Jan 31, 2024
src/axios/index.ts
Outdated
| axiosRetry(client); | ||
|
|
||
| export const DEFAULT_RETRY_COUNT = 3; | ||
| export default client; |
There was a problem hiding this comment.
can we call it retryingClient and export it non-defaultly?
package.json
Outdated
There was a problem hiding this comment.
License check (no changes, the "red" libraries have been already discussed)
|
|
||
| expect(fs.writeFile).toBeCalledWith( | ||
| '/', | ||
| new Uint8Array([84, 101, 115, 116]), |
There was a problem hiding this comment.
We mock get response with Test string, and expect that writeFile will be called with uint representation of that string. fs.writeFile is mocked, so we can check args it was called with
There was a problem hiding this comment.
Ah ok, the array in question is basically Test:
new Uint8Array([84, 101, 115, 116]).forEach((x) => console.log(String.fromCharCode(x)))
grzpab
approved these changes
Jan 31, 2024
|
|
||
| expect(fs.writeFile).toBeCalledWith( | ||
| '/', | ||
| new Uint8Array([84, 101, 115, 116]), |
There was a problem hiding this comment.
Ah ok, the array in question is basically Test:
new Uint8Array([84, 101, 115, 116]).forEach((x) => console.log(String.fromCharCode(x)))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.