Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

fix resizing issue #855

Merged

Conversation

DmytroHryshyn
Copy link
Contributor

No description provided.

Copy link

linear bot commented Jan 3, 2024

@DmytroHryshyn
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@ghost
Copy link

ghost commented Jan 3, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

// if we persist collapsed state (e.g [0, 100]), last noticed panel sizes (user's resizing) will be lost when panel is unmounted
// so we want to persist only users resizing
// collapsed state is already handled by boolean flags resultsCollapsed, changeExplorerCollapsed
if(validation.right['0,0']?.some(size => size === 0)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will have to thoroughly check this behavior during testing.

@DmytroHryshyn DmytroHryshyn merged commit b1f0371 into main Jan 3, 2024
6 checks passed
@DmytroHryshyn DmytroHryshyn deleted the 01-03-dmytro/int-2374-vsce-cannot-toggle-results-section branch January 3, 2024 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants