Merge pull request #10 from pjonsson/typescript-remove-public-modifie…

…r-test fix: typescript/remove-public-modifier: keep private/protected
codemod-com · Dec 23, 2024 · 7b83098 · 7b83098
2 parents 2bda70c + 0b4a472
commit 7b83098
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/codemods/typescript/remove-public-modifier/src/index.ts b/codemods/typescript/remove-public-modifier/src/index.ts
@@ -8,7 +8,7 @@ export default function transformer(file: FileInfo, api: API) {
     path.node.body.body.forEach((member) => {
       if (
         (member.type === "ClassMethod" || member.type === "ClassProperty") &&
-        "accessibility" in member
+        "accessibility" in member && member.accessibility === "public"
       ) {
         member.accessibility = undefined;
       }

diff --git a/codemods/typescript/remove-public-modifier/test/test.ts b/codemods/typescript/remove-public-modifier/test/test.ts
@@ -73,16 +73,20 @@ describe("remove-public-modifier", () => {
     );
   });
 
-  it("class with other modifiers (static, readonly)", () => {
+  it("class with other modifiers (private, protected, static, readonly)", () => {
     const INPUT = `
 				class MyClass {
 					public static readonly myProperty: string = 'value';
+					private secondProperty: string = 'value';
+					protected thirdProperty: string = 'value';
 				}		  
 			`;
 
     const OUTPUT = `
 				class MyClass {
 					static readonly myProperty: string = 'value';
+					private secondProperty: string = 'value';
+					protected thirdProperty: string = 'value';
 				}	
 			`;
     const fileInfo: FileInfo = {