test(cli): improve test coverage in cli api handling #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@spirulence is attempting to deploy a commit to the Codemod Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
mohebifar
reviewed
Dec 11, 2024
mohebifar
approved these changes
Dec 11, 2024
|
@mohab-sameh I got caught off-guard here by the fact that |
|
broke the above issue with linting out into it's own effort #1420 |
|
i let @amirabbas-gh to rebase and merge this, making sure his latest work is not lost. |
alexbit-codemod
assigned alexbit-codemod and amirabbas-gh and unassigned alexbit-codemod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This PR improves the unit test coverage of the cli application. New tests for
apps/cli/src/api.tsare included.Previous code coverage report (commit f3fc6be )
npx vitest --coverageNew coverage report
🔗 Linked Issue
Makes progress on #1407
🧪 Test Plan
Test only change. New tests attached. Axios and Octokit dependencies mocked where applicable.
Line 23 in api.ts appears to have an unreachable branch which could be addressed in a follow-on effort.
📄 Documentation to Update
No documentation identified.