This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
fix: yaml formatting #557
Merged
fix: yaml formatting #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzpab
reviewed
Jan 10, 2024
| @@ -429,7 +429,13 @@ export const convertToYaml = ( | |||
| } | |||
| titleWithVersion = capitalize(titleWithVersion); | |||
|
|
|||
| const shortDescription = description.split('\n').at(0); | |||
| const shortDescription = description | |||
There was a problem hiding this comment.
this can be undefined, can it be?
There was a problem hiding this comment.
technically it's not possible because split will always return a single-item array even if no splits happened
it's the native typing of at() method that causes optional chaining to be necessary. i would still prefer it over non-null assertion.
grzpab
approved these changes
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes edge-cases where yaml field can start with tilde and end with a non-word character