Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-2096 New structure of route groups #77

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

hbjORbj
Copy link

@hbjORbj hbjORbj commented Nov 1, 2023

New structure of route grouping:

  • (shared-page-wrapper)/(layout) has a shared PageWrapper in layout.tsx at the dir's root level
  • (shared-page-wrapper)/(no-layout) also has a shared PageWrapper in layout.tsx at the dir's root level but without getLayout()
  • (individual-page-wrapper) does not have a shared PageWrapper and hence does not have layout.tsx at the dir's root level at all
web/app/future
   --- (shared-page-wrapper)  
          --- (layout)
          --- (no-layout)
   --- (individual-page-wrapper)

Copy link

linear bot commented Nov 1, 2023

INT-2096 New structure of route groups

(shared-page-wrapper)  
    --- (layout)
    --- (no-layout)
(individual-page-wrapper)

Copy link

github-actions bot commented Nov 1, 2023

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "INT-2096 New structure of route groups". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@hbjORbj hbjORbj merged commit fb3bd61 into fix/structures Nov 1, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants