chore: getting-started-migration #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
DmytroHryshyn
force-pushed
the
intuita/getting-started-page
branch
from
1a90089 to
63e64a3
Compare
grzpab
reviewed
Nov 7, 2023
apps/web/app/_trpc/trpc-provider.tsx
Outdated
| @@ -118,6 +118,8 @@ export const TrpcProvider: React.FC<{ children: React.ReactNode; dehydratedState | |||
| }) | |||
| ); | |||
|
|
|||
| console.log(dehydratedState, "?????"); | |||
| }, | ||
| }; | ||
| }; | ||
| // export const getServerSideProps = async (context: GetServerSidePropsContext) => { |
| @@ -43,21 +45,22 @@ const stepTransform = (step: (typeof steps)[number]) => { | |||
| }; | |||
|
|
|||
| const stepRouteSchema = z.object({ | |||
| step: z.array(z.enum(steps)).default([INITIAL_STEP]), | |||
| step: z.enum(steps).default(INITIAL_STEP), | |||
There was a problem hiding this comment.
in pages dir in catch-all route[[...step]] param will be represented by array { step: ['value']}, but in app dir it will be just a single value
| @@ -21,6 +21,26 @@ import { | |||
|
|
|||
| import { createRecursiveProxy, createFlatProxy } from "@trpc/server/shared"; | |||
|
|
|||
| export function getArrayQueryKey( | |||
There was a problem hiding this comment.
this is a fix for issue where queryKeys returned from createTRPCNextLayout were different from keys created by @trpc/react-query
| const ssr = await ssrInit(); | ||
| await ssr.viewer.me.prefetch(); | ||
|
|
||
| console.log(await JSON.stringify(ssr.dehydrate(), null, 2), "???"); |
| throw new Error("User from session not found"); | ||
| } | ||
|
|
||
| // if (user.completedOnboarding) { |
| const h = headers(); | ||
| const nonce = h.get("x-nonce") ?? undefined; | ||
|
|
||
| // @TODO props.hasPengingInvites deprecated? |
There was a problem hiding this comment.
no, but there is some commented code that relies on this prop, i will keep it
hbjORbj
force-pushed
the
intuita/app-router-migration
branch
from
fc7e208 to
7124e5f
Compare
DmytroHryshyn
force-pushed
the
intuita/getting-started-page
branch
2 times, most recently
from
f141b21 to
5f9d301
Compare
DmytroHryshyn
force-pushed
the
intuita/getting-started-page
branch
from
5f9d301 to
25bda5c
Compare
grzpab
approved these changes
Nov 8, 2023
hbjORbj
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist