chore: [app dir bootstrapping 9] replace useSearchParams with useCompatSearchParams #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
DmytroHryshyn
changed the title
grzpab
reviewed
Oct 23, 2023
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "extends": "@calcom/tsconfig/base.json", | |||
| "compilerOptions": { | |||
| "jsx": "react", | |||
There was a problem hiding this comment.
one package that imports the hook throws error that we try to import jsx without specifying --jsx flag
DmytroHryshyn
force-pushed
the
intuita/useCompatSearchParams
branch
from
7b93252 to
e7c0c87
Compare
DmytroHryshyn
force-pushed
the
intuita/useCompatSearchParams
branch
from
e6b3f01 to
3cd45f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Applies replace-use-search-params codemod to provide consistent hook behaviour between [email protected] and [email protected] versions.
Codemod impact: 46 files changed. Estimated time saving ~1h
Requirement/Documentation
See navigation hooks comparison
Type of change
How should this be tested?
Mandatory Tasks