Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B-13] Create the app/not-found.tsx page #25

Closed
wants to merge 5 commits into from

Conversation

DmytroHryshyn
Copy link

What does this PR do?

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[B-13] Create the app/not-found.tsx page". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@DmytroHryshyn DmytroHryshyn changed the title Dmytro/404 [B-13] Create the app/not-found.tsx page Oct 2, 2023
@DmytroHryshyn DmytroHryshyn changed the base branch from main to intuita/newLayout October 9, 2023 10:27
@DmytroHryshyn DmytroHryshyn force-pushed the intuita/newLayout branch 3 times, most recently from 6b37c70 to f3b1f5a Compare October 18, 2023 09:55
@grzpab grzpab force-pushed the intuita/newLayout branch 5 times, most recently from 1965df3 to 3d05a13 Compare October 25, 2023 07:52
@DmytroHryshyn DmytroHryshyn changed the base branch from intuita/newLayout to intuita/app-router-migration October 26, 2023 10:12
@hbjORbj hbjORbj force-pushed the intuita/app-router-migration branch from fc7e208 to 7124e5f Compare November 7, 2023 17:33
@grzpab grzpab force-pushed the intuita/app-router-migration branch 2 times, most recently from d5942eb to b802bc5 Compare November 9, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant