Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove router groups, add LayoutHOC #156

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

DmytroHryshyn
Copy link

What does this PR do?

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link

github-actions bot commented Dec 29, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@DmytroHryshyn DmytroHryshyn changed the title Chore/make no meeting found page ssr chore: remove router groups, add LayoutHOC Jan 2, 2024
import PageWrapper from "@components/PageWrapperAppDir";

type WithLayoutParams<T> = {
getLayout?: ((page: React.ReactElement) => JSX.Element) | null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we should always ensure getLayout parameter is at least null?

nonce={nonce}
themeBasis={null}
{...props}>
{Page ? props ? <Page {...props} /> : <></> : "children" in restProps ? restProps.children : <></>}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. are these nested ternary expressions? (hard to follow them, perhaps we should use a helper variable?)
  2. can we replace <></> with null?

@DmytroHryshyn DmytroHryshyn merged commit cec96c1 into main Jan 4, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants