Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-2215 Migrate '/insights' page #130

Closed
wants to merge 5 commits into from

Conversation

hbjORbj
Copy link

@hbjORbj hbjORbj commented Nov 28, 2023

This PR is on top of [app-router-migration-1] chore: migrate the pages in settings/admin to the app directory

What does this PR do?

  • This PR migrates the /insights page to the app directory (which runs under the App Router).
  • The migrated page exists under /future and is accessible at all times.

Requirement/Documentation

  • Performance metric for /insights page (App Router vs Pages Router) can be found here

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)

How should this be tested?

  1. Setup the environment variable AB_TEST_BUCKET_PROBABILITY to 100
  2. Setup the environment variable APP_ROUTER_INSIGHTS_ENABLED to 1
  3. Run the application
  4. Navigate to /insights

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@hbjORbj
Copy link
Author

hbjORbj commented Nov 28, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

github-actions bot commented Nov 28, 2023

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "INT-2215 Migrate '/insights' page". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@hbjORbj hbjORbj changed the base branch from main to 11-23-codemod_app-directory-boilerplate-calcom November 28, 2023 14:54
@hbjORbj hbjORbj force-pushed the 11-28-intuita_codemod_remove-get-static-props branch 2 times, most recently from 5e72dec to 61b8785 Compare November 28, 2023 15:01
@hbjORbj hbjORbj changed the title Migrate '/insights' page INT-2215 Migrate '/insights' page Nov 29, 2023
Copy link

linear bot commented Nov 29, 2023

@hbjORbj hbjORbj force-pushed the 11-28-intuita_codemod_remove-get-static-props branch from 61b8785 to 3b203bc Compare November 29, 2023 14:34
@hbjORbj hbjORbj changed the base branch from 11-23-codemod_app-directory-boilerplate-calcom to main November 29, 2023 18:14
Copy link

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added Stale and removed Stale labels Dec 15, 2023
Copy link

github-actions bot commented Jan 5, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jan 5, 2024
Amit91848 and others added 5 commits January 5, 2024 13:20
* Changed dynamic to group meeting and udpated meta

* type fix

* Update packages/features/bookings/components/BookerSeo.tsx

* Update packages/features/eventtypes/lib/getPublicEvent.ts

* Update packages/features/bookings/components/BookerSeo.tsx

* Update packages/features/eventtypes/lib/getPublicEvent.ts

* Update getPublicEvent.ts

* Apply suggestions from code review

* Update packages/lib/defaultEvents.ts

* Update packages/lib/defaultEvents.ts

* Update packages/lib/defaultEvents.ts

* Update packages/lib/defaultEvents.ts

---------

Co-authored-by: Peer Richelsen <[email protected]>
Co-authored-by: Peer Richelsen <[email protected]>
@hbjORbj hbjORbj force-pushed the 11-28-intuita_codemod_remove-get-static-props branch from 979ffe5 to 5daf52d Compare January 5, 2024 14:05
@hbjORbj hbjORbj closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants