Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT-2162: Migration of settings/admin directory #123

Closed
wants to merge 10 commits into from
Closed

INT-2162: Migration of settings/admin directory #123

wants to merge 10 commits into from

Conversation

hbjORbj
Copy link

@hbjORbj hbjORbj commented Nov 23, 2023 •
edited
Loading

No description provided.

@hbjORbj
Copy link
Author

hbjORbj commented Nov 23, 2023 •
edited by DmytroHryshyn
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "INT-2162: Migration of settings/admin directory". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@hbjORbj hbjORbj changed the title Migration of settings/admin directory INT-2162: Migration of settings/admin directory Nov 23, 2023
@linear Linear
Copy link

linear bot commented Nov 23, 2023

INT-2162 Prepare migration of "settings/admin" to open a PR at cal.com repo

@hbjORbj hbjORbj force-pushed the 11-23-codemod_app-directory-boilerplate-calcom branch 2 times, most recently from 2443064 to ca82cfc Compare November 24, 2023 10:06
DmytroHryshyn
DmytroHryshyn reviewed Nov 24, 2023
View reviewed changes
apps/web/components/auth/layouts/AdminLayoutAppDir.tsx
// Force redirect on component level
useEffect(() => {
if (session.data && session.data.user.role !== UserPermissionRole.ADMIN) {
router.replace("/settings/my-account/profile");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work in app dir?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so

grzpab
grzpab reviewed Nov 24, 2023
View reviewed changes
apps/web/app/future/(shared-page-wrapper)/(admin-layout)/settings/admin/flags/page.tsx

export const generateMetadata = async () =>
await _generateMetadata(
() => "Feature Flags",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not translated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope according to the legacy page.

grzpab
grzpab reviewed Nov 24, 2023
View reviewed changes
apps/web/app/future/(shared-page-wrapper)/(admin-layout)/settings/admin/page.tsx

export const generateMetadata = async () =>
await _generateMetadata(
() => "Admin",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not translated?

Copy link
Author

@hbjORbj hbjORbj Nov 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope according to the legacy page.

grzpab
grzpab reviewed Nov 24, 2023
View reviewed changes
.../web/app/future/(shared-page-wrapper)/(admin-layout)/settings/admin/users/[id]/edit/page.tsx Outdated

return await _generateMetadata(
() => title,
() => "Here you can edit a current user."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no translation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope according to the legacy page.

@hbjORbj hbjORbj force-pushed the 11-23-codemod_app-directory-boilerplate-calcom branch from 2ea7650 to 8b0618e Compare November 24, 2023 13:16
This was referenced Nov 27, 2023
Merged
Closed
@DmytroHryshyn DmytroHryshyn force-pushed the 11-23-codemod_app-directory-boilerplate-calcom branch 2 times, most recently from 33aa8a6 to 4d1a696 Compare November 27, 2023 14:07
@DmytroHryshyn DmytroHryshyn mentioned this pull request Nov 27, 2023
Merged
6 tasks
@DmytroHryshyn DmytroHryshyn force-pushed the 11-23-codemod_app-directory-boilerplate-calcom branch from 08ec308 to 3af846b Compare November 27, 2023 16:09
@DmytroHryshyn DmytroHryshyn mentioned this pull request Nov 27, 2023
Closed
6 tasks
@hbjORbj hbjORbj force-pushed the 11-23-codemod_app-directory-boilerplate-calcom branch from a56b2c9 to f07f631 Compare November 28, 2023 07:11
@hbjORbj hbjORbj force-pushed the 11-23-codemod_app-directory-boilerplate-calcom branch from f07f631 to ff5adbe Compare November 28, 2023 07:13
@DmytroHryshyn DmytroHryshyn force-pushed the 11-23-codemod_app-directory-boilerplate-calcom branch from ff5adbe to 0c26303 Compare November 28, 2023 13:19
@DmytroHryshyn DmytroHryshyn mentioned this pull request Nov 28, 2023
Merged
6 tasks
@hbjORbj
Copy link
Author

hbjORbj commented Nov 28, 2023

we opened a PR for this branch at cal repo; hence, closing.

@hbjORbj hbjORbj closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroHryshyn DmytroHryshyn DmytroHryshyn left review comments

@grzpab grzpab grzpab left review comments

Assignees
No one assigned
Labels
❗️ .env changes ❗️ migrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @grzpab @DmytroHryshyn