Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 타입스크립트 다운 그레이드 - react-hook-form 설치
- custom.d.ts 추가 - 파일 이동 - 디자인 수정
Il9
reviewed
Jun 15, 2024
| children: ReactNode | ||
| } | ||
|
|
||
| const AuthContent = ({ onSubmit, children }: AuthContentProps) => ( |
There was a problem hiding this comment.
AuthContent보단 AuthFormWrapper?같은게 어울릴 것 같습니다
공용으로 사용해야하는 복잡한게 컴포넌트에 있는 것도 아니니 회원가입 로그인 form을 그냥 두개 만드시는 것도 좋은 방법일 것 같네요
Comment on lines
+12
to
+19
| const navigate = useNavigate(); | ||
|
|
||
| useEffect(() => { | ||
| const accessToken = localStorage.getItem("accessToken"); | ||
| if (accessToken) { | ||
| navigate('/'); | ||
| } | ||
| }, [navigate]); |
There was a problem hiding this comment.
저라면 CenterLIne이라는 컴포넌트가 이 로직을 들고 있을지 상상도 못할 것 같습니다.
이런 방법을 추천드립니다.
| @@ -8,25 +7,28 @@ import profile from "../assets/profileIcon.svg"; | |||
|
|
|||
| function Nav() { | |||
| const { pathname } = useLocation(); | |||
| const accessToken = localStorage.getItem("accessToken"); | |||
There was a problem hiding this comment.
유저와 관련된 값들은 재사용될 확률이 높으니 별도 hook으로 만들어 두시면 좋을 것 같습니다.
| @@ -1,6 +1,16 @@ | |||
| import { useState, useEffect } from 'react'; | |||
|
|
|||
| function usePagination(initialPage = 1, totalCount, pageSize, asyncFunction) { | |||
| type AsyncFunction<T> = (...args: any[]) => Promise<T>; | |||
Comment on lines
+1
to
+16
| export interface ProductItem { | ||
| createdAt: string; | ||
| favoriteCount: number; | ||
| ownerId: number; | ||
| images: string; | ||
| tags: string[]; | ||
| price: number; | ||
| description: string; | ||
| name: string; | ||
| id: number; | ||
| } | ||
|
|
||
| export interface Product { | ||
| list: ProductItem[]; | ||
| totalCount?: number; | ||
| } |
There was a problem hiding this comment.
ProductItem이 Product가되고
Product가 ProductResponse같은게 되면 더 낫지않을까 싶습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
랜딩 페이지
로그인
회원가입
심화
주요 변경사항
질문