Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
ding-co
reviewed
Jun 9, 2024
There was a problem hiding this comment.
components/Header/index.tsx 로 하면 import 할 때 중복으로 Header/Header 이렇게 안써도 되는 것 참고해주세요~
There was a problem hiding this comment.
tailwind 스타일이 우선적으로 적용되어 있어서 만약 기본 스타일을 추가하거나 수정하고 싶으시면
@layer base 이런 것들을 활용하시면 좋을 것 같아요.
There was a problem hiding this comment.
이렇게 각각 type을 export 하셔도 되고 아니면 맨 아래에서 export type { Article, ArticleListResponse } 한번에 모아서도 가능한 것 참고해주세요~
There was a problem hiding this comment.
파일명을 date로 바꾸는게 확장성에서 좋을 것 같아요~
| @@ -0,0 +1,9 @@ | |||
| export function formatDate(date: Date): string { | |||
There was a problem hiding this comment.
format한 date를 얻는 것이기 때문에 getFormatDate라고 해도 괜찮을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
멘토에게