Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
…-sprint1 [김유정] Sprint1
… into part1-김유정-sprint1
…정-sprint2 [김유정] Sprint2
…정-sprint3 [김유정] Sprint3
airman5573
reviewed
Jun 17, 2024
| @@ -0,0 +1,23 @@ | |||
| module.exports = { | |||
|
|
||
| function Button({ children }) { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
[수정해주세요]
여기서 Fragment는 지우셔도 됩니다
| import Profile from "../assets/images/profile.png"; | ||
| import "../styles/Header.css"; | ||
| import { Link, NavLink } from 'react-router-dom'; | ||
| import Logo from '@/assets/images/logo.png'; |
There was a problem hiding this comment.
absolute path를 사용하셨군요 👍
| }`; | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
[수정해주세요]
여기서 Fragment는 없어도 됩니다!
| name="item_name" | ||
| placeholder="상품명을 입력해주세요" | ||
| /> | ||
| <div className={styles.label}>상품 이미지</div> |
There was a problem hiding this comment.
[참고해주세요]
여기서는 div대신 label이 더 잘어울립니다!
그래야 '상품 이미지'를 클릭했을때 input에 focus가 생깁니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게