Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[김승래] Sprint1 #46

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,33 @@

### 기본

- [x]
- []
- []
- [x] 랜딩 페이지의 url path는 루트(‘/’)로 설정합니다.
- [x] title은 “판다마켓”로 설정합니다.
- [x] 화면의 너비가 1920px 이상이면 하늘색 배경색은 너비를 꽉 채우도록 채워지고, 내부 요소들의 위치는 고정되고, 여백만 커지도록 합니다.
- [x] 화면의 너비가 1920px 보다 작아질 때, “판다마켓” 로고의 왼쪽 여백 200px“로그인" 버튼의 오른쪽 여백 200px이 유지되고, 화면의 너비가 작아질수록 두 요소간 거리가 가까워지도록 설정합니다.
- [x] 클릭으로 기능이 동작해야 하는 경우, 사용자가 클릭할 수 있는 요소임을 알 수 있도록 CSS 속성 cursor: pointer 로 설정합니다.
- [x] “판다마켓” 클릭 시 루트 페이지(‘/’)로 이동합니다.
- [x] '로그인'버튼 클릭 시 로그인 페이지(‘/login’)로 이동합니다 (빈 페이지)
- [x] “구경하러가기”버튼 클릭 시(’/items’)로 이동합니다.(빈 페이지)
- [x] “Privacy Policy”, “FAQ”는 클릭 시 각각 Privacy 페이지(‘/privacy’), FAQ 페이지(‘/faq’)로 이동합니다.(모두 빈 페이지)
- [x] 페이스북, 트위터, 유튜브, 인스타그램 아이콘을 클릭 시 각각의 홈페이지로 새로운 창이 열리면서 이동합니다.

### 심화

- [x]
- []
- [] palette에 있는 color값들을 css 변수로 등록하고 사용해 주세요.
- [] 사용자의 브라우저가 크고 작아짐에 따라 페이지의 요소간 간격, 요소의 크기, font-size 등 모든 크기와 관련된 값이 크고 작아지도록 설정해보세요.

## 주요 변경사항

-
-
-
-

## 스크린샷

![image](이미지url)

## 멘토에게

-
-
-
-
- 셀프 코드 리뷰를 통해 질문 이어가겠습니다.
11 changes: 11 additions & 0 deletions mission_1/faq.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lang="ko"로 써주신곳도 있는것 같은데, 아예 ko로 통일해주시면 좋을것 같아요!

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>FAQ</title>
</head>
<body>

</body>
</html>
Binary file added mission_1/images/Img_home_01.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지의 파일명은 소문자로 써주시면 좋습니다!

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added mission_1/images/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added mission_1/images/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added mission_1/images/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added mission_1/images/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added mission_1/images/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added mission_1/images/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added mission_1/images/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added mission_1/images/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added mission_1/images/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
140 changes: 140 additions & 0 deletions mission_1/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,140 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="style.css" />
<title>판다마켓</title>
</head>
<body>
<!-- header -->
<header>
<div class="header_container">
<a href="index.html"><img src="images/logo.png" alt="판다마켓_로고"/></a>
<a href="signin.html"><button>로그인</button></a>
</div>
</header>
<!-- header -->

<!-- top_banner -->
<div class="top_banner">
<div class="top_banner_container">
<div class="top_banner_container_look">
<h1>
일상의 모든 물건을<br />
거래해 보세요
</h1>
<button type="button" onclick="location.href='items.html'">
구경하러 가기
</button>
</div>
<img src="images/Img_home_top.png" alt="판다마켓_탑_배너_이미지" />
</div>
</div>
<!-- top_banner -->

<!-- main -->
<main>
<section>
<img src="images/Img_home_01.png" alt="메인_섹션_이미지_1" />
<div class="section_container">
<h3>Hot item</h3>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 태그간의 구분을 위한 개행은 굳이 하지않는 편입니다. 개행하지 않아도 다 알아볼 수 있기 때문이죠!

<h1>
인기상품을 <br />
확인해보세요
</h1>

<p>
가장 HOT한 중고거래 물품을 판다<br />
마켓에서 확인해 보세요
</p>
</div>
</section>

<section>
<div class="section_container">
<h3>Search</h3>

<h1>
구매를 원하는<br />
상품을 검색하세요
</h1>

<p>
구매하고 싶은 물품은<br />
검색해서 쉽게 찾아보세요
</p>
</div>
<img src="images/Img_home_02.png" alt="메인_섹션_이미지_2" />
</section>

<section>
<img src="images/Img_home_03.png" alt="메인_섹션_이미지_3" />
<div class="section_container">
<h3>Register</h3>

<h1>
판매를 원하는<br />
상품을 등록하세요
</h1>

<p>
어떤 물건이든 판매하고<br />
싶은 상품을 쉽게 등록하세요
</p>
</div>
</section>
</main>
<!-- main -->

<!-- bottom_banner -->
<div class="bottom_banner">
<div class="bottom_banner_container">
<h1>믿을 수 있는 <br />판다마켓 중고거래</h1>

<img src="images/Img_home_bottom.png" alt="판다마켓_바텀_배너_이미지" />
</div>
</div>
<!-- bottom_banner -->

<!-- footer -->
<footer>
<div class="footer_container">
<div iv class="footer_year">
<p>©codeit - 2024</p>
</div>

<div class="footer_privacy_faq">
<p>Privacy Policy</p>
<p>FAQ</p>
</div>

<div class="footer_SNS">
<a href="https://www.facebook.com/" target="_blank">
<img src="images/ic_facebook.png" alt="페이스북_아이콘" />
</a>

<a href="https://twitter.com/" target="_blank">
<img src="images/ic_twitter.png" alt="트위터_아이콘" />
</a>

<a href="https://www.youtube.com/" target="_blank">
<img src="images/ic_youtube.png" alt="유튜브_아이콘" />
</a>

<a href="https://www.instagram.com/" target="_blank">
<img src="images/ic_instagram.png" alt="인스타그램_아이콘" />
</a>
</div>
</div>
</footer>
<!-- footer -->
</body>
</html>
11 changes: 11 additions & 0 deletions mission_1/items.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기는 특히 한글이 들어가서 더더욱 ko로 바꿔주시면 좋을것 같습니다.

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>상품페이지</title>
</head>
<body>

</body>
</html>
11 changes: 11 additions & 0 deletions mission_1/privacy.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Privacy</title>
</head>
<body>

</body>
</html>
11 changes: 11 additions & 0 deletions mission_1/signin.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>로그인_페이지</title>
</head>
<body>

</body>
</html>
Loading
Loading