-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[week15] 배의진 #486
The head ref may contain hidden characters: "part3-\uBC30\uC758\uC9C4-week15"
[week15] 배의진 #486
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { Form } from "@/src/components-sign/feature-form/Form"; | ||
import { Header } from "@/src/components-sign/ui-header/Header"; | ||
import { Sns } from "@/src/components-sign/ui-sns/Sns"; | ||
import { SignLayout } from "@/src/page-layout/SignLayout/SignLayout"; | ||
|
||
export default function SignUpPage() { | ||
return <SignLayout header={<Header />} form={<Form />} sns={<Sns />} />; | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,45 @@ export const route = { | |
FAQ: "/faq", | ||
}; | ||
|
||
export const text = { | ||
login: "로그인", | ||
signup: "회원가입", | ||
addLink: "링크 추가하기", | ||
}; | ||
|
||
export const kakao = { | ||
url: "https://www.kakaocorp.com/page/", | ||
src: "/images/kakao.svg", | ||
alt: "카카오 홈페이지로 연결된 카카오 로고", | ||
}; | ||
export const google = { | ||
url: "https://www.google.com/", | ||
src: "/images/google.png", | ||
alt: "구글 홈페이지로 연결된 구글 로고", | ||
}; | ||
export const twitter = { | ||
url: "https://twitter.com/", | ||
src: "/images/twitter.svg", | ||
alt: "트위터 홈페이지로 연결된 트위터 로고", | ||
}; | ||
export const youtube = { | ||
url: "'https://www.youtube.com/", | ||
src: "/images/youtube.svg", | ||
alt: "유투브 홈페이지로 연결된 유투브 로고", | ||
}; | ||
export const facebook = { | ||
url: "https://www.facebook.com/", | ||
src: "/images/facebook.svg", | ||
alt: "페이스북 홈페이지로 연결된 페이스북 로고", | ||
}; | ||
export const instagram = { | ||
url: "https://www.instagram.com/", | ||
src: "/images/instagram.svg", | ||
alt: "인스타그램 홈페이지로 연결된 인스타그램 로고", | ||
}; | ||
|
||
export const logoImage = "images/linkbrary.svg"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이....건 굳이 상수 폴더에 있을 필요는 없을 것 같고 그냥 사용하는곳에서 import해오는게 좋아보입니다! |
||
|
||
const second = 1000; | ||
const minute = second * 60; | ||
const hour = minute * 60; | ||
|
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,8 +44,8 @@ | |
} | ||
|
||
.icon { | ||
width: 1.6rem; | ||
height: 1.6rem; | ||
width: 1.6rem; | ||
|
||
@include tablet { | ||
width: 2rem; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { axiosInstance } from "@/src/components-common/util"; | ||
|
||
export const checkAccountAlreadyExist = async ( | ||
id: string | ||
): Promise<boolean> => { | ||
const address = "check-email"; | ||
try { | ||
const response = await axiosInstance.post(address, { email: id }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이건 그냥 const response = await axiosInstance.post('/check-email', { email: id }); 이렇게 해주시면 될 것 같습니다 ㅎ 너무 변수를 남발하는 것도 ......굳이..라는 생각이 좀 드네요 😅
|
||
return response.status === 200; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오잉..? 통신이 성공했는지 안했는지를 반환하나요? |
||
} catch (error) { | ||
alert("계정이 이미 존재합니다."); | ||
return false; | ||
} | ||
}; | ||
|
||
export const checkAccountValid = async ( | ||
id: string, | ||
pwd: string | ||
): Promise<boolean> => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
const address = "sign-up"; | ||
const account = { email: id, password: pwd }; | ||
try { | ||
const response = await axiosInstance.post(address, account); | ||
return response.status === 200; | ||
} catch (error) { | ||
alert("계정 정보가 잘못되었습니다."); | ||
return false; | ||
} | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
@import "@/styles/global.scss"; | ||
|
||
.container { | ||
display: flex; | ||
flex-direction: column; | ||
align-items: flex-start; | ||
row-gap: 2.4rem; | ||
width: 100%; | ||
|
||
& > :last-child { | ||
margin-top: 0.6rem; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기본적으로 상수의 네이밍 컨벤션은 상수스타일이라고
모든 문자를 대문자, 문자와 문자사이는
_
로 네이밍 하는 규칙이 일반적입니다!ex) TEXT, KAKAO, CONSTANT_NAME, 이런식으로요!