-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for multiple permissions check for users #791
Merged
kenjis
merged 7 commits into
codeigniter4:develop
from
sammyskills:support-multiple-permissions
Aug 22, 2023
Merged
feat: add support for multiple permissions check for users #791
kenjis
merged 7 commits into
codeigniter4:develop
from
sammyskills:support-multiple-permissions
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonnieezell
approved these changes
Aug 16, 2023
datamweb
changed the title
Add support for multiple permissions check for users.
feat: add support for multiple permissions check for users
Aug 17, 2023
datamweb
reviewed
Aug 17, 2023
datamweb
reviewed
Aug 17, 2023
kenjis
reviewed
Aug 18, 2023
kenjis
reviewed
Aug 21, 2023
The implementation looks good. |
@sammyskills maybe add test also for wildcard case |
Co-authored-by: kenjis <[email protected]>
sammyskills
force-pushed
the
support-multiple-permissions
branch
from
August 21, 2023 07:52
8ae0f85
to
6d9e5be
Compare
Yes, you are correct @jozefrebjak. I have added that now. |
datamweb
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@sammyskills and @jozefrebjak thanks.
kenjis
approved these changes
Aug 22, 2023
@sammyskills Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for multiple permissions check for users via the
Authorizable
trait.With this pull request, instead of writing:
we use this: