Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update phpstan-baseline.php #1161

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 12, 2024

Description
Run vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P:\MyGitHubWork\shield>php vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
Note: Using configuration file P:\MyGitHubWork\shield\phpstan.neon.dist.
 196/196 [============================] 100%



 [OK] Baseline generated with 137 errors.

The fact is that because of the length of the php vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php I never use it.
I choose to use command composer analyze.

Composer may need to be updated.

@kenjis kenjis merged commit a0fcea8 into codeigniter4:develop Aug 12, 2024
34 checks passed
@kenjis kenjis deleted the update-phpstan-baseline branch August 12, 2024 07:46
@kenjis
Copy link
Member Author

kenjis commented Aug 12, 2024

The --generate-baseline option updates the baseline file.
We don't need to update it normally because we should not add lines in the baseline file.

In this time, I've got too many conflicts when git rebasing. So I've used it and found the new comment lines.

If you want a composer command to update the baseline,
https://github.com/codeigniter4/CodeIgniter4/blob/f60d27702b6844826343619755340b66faff9383/composer.json#L124-L125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants