Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update psalm.xml #1089

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 8, 2024

Description
Update to fix errors with CI 4.5.0 like:

Error: src/Auth.php:54:15: MissingDependency: CodeIgniter\Shield\Models\UserModel depends on class or interface codeigniter\basemodel that does not exist (see https://psalm.dev/157)
Error: src/Auth.php:139:23: UndefinedFunction: Function CodeIgniter\Shield\config does not exist (see https://psalm.dev/021)
Error: src/Auth.php:162:36: MissingDependency: CodeIgniter\Shield\Models\UserModel depends on class or interface codeigniter\basemodel that does not exist (see https://psalm.dev/157)

CI 4.5.0 requires PHP 8.1 or later.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

PHP 7.4 causes UndefinedFunction errors.

Error: src/Auth.php:54:15: MissingDependency: CodeIgniter\Shield\Models\UserModel depends on class or interface codeigniter\basemodel that does not exist (see https://psalm.dev/157)
It is better to set "true" but if true, many error will be reported.
So set "false" for now.
@kenjis kenjis merged commit 0894a16 into codeigniter4:develop Apr 8, 2024
3 checks passed
@kenjis kenjis deleted the update-psalm.xml branch April 8, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants