Merge pull request #1222 from samsonasik/refactor-move-property-to-lo…

…cal-var-on-test refactor: Move property to local variable on usage only in setUp() method in tests
codeigniter4 · Nov 5, 2024 · 86b62c4 · 86b62c4
2 parents bb87c07 + ba62a54
commit 86b62c4
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 12 deletions.
diff --git a/tests/Authentication/Authenticators/SessionAuthenticatorTest.php b/tests/Authentication/Authenticators/SessionAuthenticatorTest.php
@@ -36,8 +36,6 @@ final class SessionAuthenticatorTest extends DatabaseTestCase
     use FakeUser;
 
     private Session $auth;
-    protected $namespace;
-    private MockEvents $events;
 
     protected function setUp(): void
     {
@@ -51,8 +49,8 @@ protected function setUp(): void
         $authenticator = $auth->factory('session');
         $this->auth    = $authenticator;
 
-        $this->events = new MockEvents();
-        Services::injectMock('events', $this->events);
+        $events = new MockEvents();
+        Services::injectMock('events', $events);
 
         $this->db->table($this->tables['identities'])->truncate();
     }

diff --git a/tests/Authentication/Filters/JWTFilterTest.php b/tests/Authentication/Filters/JWTFilterTest.php
@@ -31,8 +31,6 @@ final class JWTFilterTest extends DatabaseTestCase
 {
     use FeatureTestTrait;
 
-    protected $namespace;
-
     protected function setUp(): void
     {
         Services::reset(true);

diff --git a/tests/Authentication/MagicLinkTest.php b/tests/Authentication/MagicLinkTest.php
@@ -30,7 +30,6 @@ final class MagicLinkTest extends DatabaseTestCase
     use FeatureTestTrait;
 
     protected $refresh = true;
-    protected $namespace;
 
     protected function setUp(): void
     {

diff --git a/tests/Authorization/AuthorizableTest.php b/tests/Authorization/AuthorizableTest.php
@@ -29,7 +29,6 @@ final class AuthorizableTest extends DatabaseTestCase
     use FakeUser;
 
     protected $refresh = true;
-    protected $namespace;
 
     protected function setUp(): void
     {

diff --git a/tests/Controllers/LoginTest.php b/tests/Controllers/LoginTest.php
@@ -31,8 +31,6 @@ final class LoginTest extends DatabaseTestCase
     use FeatureTestTrait;
     use FakeUser;
 
-    protected $namespace;
-
     protected function setUp(): void
     {
         parent::setUp();

diff --git a/tests/Controllers/RegisterTest.php b/tests/Controllers/RegisterTest.php
@@ -33,8 +33,6 @@ final class RegisterTest extends DatabaseTestCase
     use FeatureTestTrait;
     use FakeUser;
 
-    protected $namespace;
-
     protected function setUp(): void
     {
         Services::reset(true);